MDL-43020: Fix calculation of lesson scale value warning

This commit is contained in:
Tim Lock
2013-11-27 07:40:21 +10:30
parent 7b52944b5e
commit 20d1fea57f
+4 -2
View File
@@ -470,8 +470,10 @@ function lesson_grade_item_update($lesson, $grades=null) {
$params['scaleid'] = -$lesson->grade;
// When converting a score to a scale, use scale's grade maximum to calculate it.
$grade = grade_get_grades($lesson->course, 'mod', 'lesson', $lesson->id, reset($grades)->userid);
$params['grademax'] = reset($grade->items)->grademax;
if (!empty($grades)) {
$grade = grade_get_grades($lesson->course, 'mod', 'lesson', $lesson->id, reset($grades)->userid);
$params['grademax'] = reset($grade->items)->grademax;
}
} else {
$params['gradetype'] = GRADE_TYPE_NONE;
}