L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

course settings: MDL-17501 fix potential problem for people upgrading 1.6 -> 1.9.4.

Browse Source 
I am amazed that Petr spotted this. Great catch.
This commit is contained in:
tjhunt
2008-12-09 04:49:06 +00:00
parent aaae02a573
commit 20cd50e2e7
1 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/db/upgrade.php
+13 -11
View File
@@ -3076,20 +3076,22 @@ function xmldb_main_upgrade($oldversion=0) {
/// For MDL-17501. Ensure that any role that has moodle/course:update also
/// has moodle/course:visibility.
if ($result && $oldversion < 2007101532.10) {
/// Get the roles with 'moodle/course:update'.
$systemcontext = get_context_instance(CONTEXT_SYSTEM);
$roles = get_roles_with_capability('moodle/course:update', CAP_ALLOW, $systemcontext);
if (!empty($CFG->rolesactive)) { // In case we are upgrading from Moodle 1.6.
/// Get the roles with 'moodle/course:update'.
$systemcontext = get_context_instance(CONTEXT_SYSTEM);
$roles = get_roles_with_capability('moodle/course:update', CAP_ALLOW, $systemcontext);
/// Give those roles 'moodle/course:visibility'.
foreach ($roles as $role) {
assign_capability('moodle/course:visibility', CAP_ALLOW, $role->id, $systemcontext->id);
/// Give those roles 'moodle/course:visibility'.
foreach ($roles as $role) {
assign_capability('moodle/course:visibility', CAP_ALLOW, $role->id, $systemcontext->id);
}
/// Force all sessions to refresh access data.
mark_context_dirty($systemcontext->path);
}
/// Force all sessions to refresh access data.
mark_context_dirty($systemcontext->path);
/// Main savepoint reached
upgrade_main_savepoint($result, 2007101532.10);
/// Main savepoint reached
upgrade_main_savepoint($result, 2007101532.10);
}
return $result;