L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-85474 assign: fix call to undefined 'view_error_page' method

Browse Source 
And while doing so, fix $notices parameters that ought to be call-by-
reference to collect notices produced during calls to
process_submit_other_for_grading() and process_submit_for_grading().
This commit is contained in:
Jonathon Fowler
2025-10-21 10:09:35 +10:00
parent 21be86fb7f
commit 2030a3d87b
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/mod/assign/locallib.php
+7 -3
View File
@@ -705,7 +705,7 @@ class assign {
} else if ($action == 'viewbatchmarkingallocation') {
$o .= $this->view_batch_markingallocation();
} else if ($action == 'viewsubmitforgradingerror') {
$o .= $this->view_error_page(get_string('submitforgrading', 'assign'), $notices);
$o .= $this->view_notices(get_string('submitforgrading', 'assign'), $notices);
} else if ($action == 'fixrescalednullgrades') {
$o .= $this->view_fix_rescaled_null_grades();
} else {
@@ -7003,9 +7003,12 @@ class assign {
/**
* A students submission is submitted for grading by a teacher.
*
* @param moodleform|null $mform If validation failed when submitting this form - this is the moodleform.
* It can be null.
* @param array $notices Receives error messages to display on an error condition.
* @return bool
*/
protected function process_submit_other_for_grading($mform, $notices) {
protected function process_submit_other_for_grading($mform, &$notices) {
global $USER, $CFG;
require_sesskey();
@@ -7026,9 +7029,10 @@ class assign {
*
* @param moodleform|null $mform If validation failed when submitting this form - this is the moodleform.
* It can be null.
* @param array $notices Receives error messages to display on an error condition.
* @return bool Return false if the validation fails. This affects which page is displayed next.
*/
protected function process_submit_for_grading($mform, $notices) {
protected function process_submit_for_grading($mform, &$notices) {
global $CFG;
require_once($CFG->dirroot . '/mod/assign/submissionconfirmform.php');