L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-68262 assignfeedback_editpdf: Update unit test for latest coding style

Browse Source
This commit is contained in:
Andrew Nicols
2024-05-29 16:21:46 +08:00
committed by Jun Pataleta
parent ab312b111a
commit 1f2f8d511f
1 changed files with 9 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/feedback/editpdf/tests/document_services_test.php
+9 -18
View File
@@ -16,10 +16,6 @@
namespace assignfeedback_editpdf;
use mod_assign_test_generator;
use advanced_testcase;
use ReflectionMethod;
defined('MOODLE_INTERNAL') || die();
global $CFG;
@@ -30,18 +26,17 @@ require_once($CFG->dirroot . '/mod/assign/tests/generator.php');
*
* @package assignfeedback_editpdf
* @category test
* @covers \assignfeedback_editpdf\document_services
* @copyright 2022 Mikhail Golenkov <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @covers \assignfeedback_editpdf\document_services
*/
class document_services_test extends advanced_testcase {
use mod_assign_test_generator;
final class document_services_test extends \advanced_testcase {
use \mod_assign_test_generator;
/**
* Test that the save file method saves the file.
* @covers ::save_file()
*/
public function test_save_file_saves_the_file() {
public function test_save_file_saves_the_file(): void {
global $DB;
$this->resetAfterTest();
@@ -50,12 +45,11 @@ class document_services_test extends advanced_testcase {
$user = $this->getDataGenerator()->create_user();
$this->getDataGenerator()->enrol_user($user->id, $course->id, 'student');
$method = new ReflectionMethod('\assignfeedback_editpdf\document_services', 'save_file');
$method->setAccessible(true);
$method = new \ReflectionMethod('\assignfeedback_editpdf\document_services', 'save_file');
$filearea = document_services::TMP_ROTATED_JPG_FILEAREA;
$content = 'some random content';
$tempfile = make_temp_directory('assignfeedback_editpdf') . DIRECTORY_SEPARATOR . 'mock.file';
$tempfile = make_request_directory('assignfeedback_editpdf') . DIRECTORY_SEPARATOR . 'mock.file';
file_put_contents($tempfile, $content);
// Invoke the method and confirm, that the file is saved.
@@ -70,9 +64,8 @@ class document_services_test extends advanced_testcase {
/**
* Test that save_rotated_image_file() method saves the file.
* @covers ::save_rotated_image_file()
*/
public function test_save_rotated_image_file_saves_the_file() {
public function test_save_rotated_image_file_saves_the_file(): void {
global $CFG, $DB;
$this->resetAfterTest();
@@ -81,8 +74,7 @@ class document_services_test extends advanced_testcase {
$user = $this->getDataGenerator()->create_user();
$this->getDataGenerator()->enrol_user($user->id, $course->id, 'student');
$method = new ReflectionMethod('\assignfeedback_editpdf\document_services', 'save_rotated_image_file');
$method->setAccessible(true);
$method = new \ReflectionMethod('\assignfeedback_editpdf\document_services', 'save_rotated_image_file');
$imagecontent = file_get_contents($CFG->dirroot . '/lib/filestorage/tests/fixtures/testimage.png');
$imageresource = imagecreatefromstring($imagecontent);
@@ -99,9 +91,8 @@ class document_services_test extends advanced_testcase {
/**
* Test that get_combined_document_for_attempt() method rotates the image only once.
* @covers ::get_combined_document_for_attempt()
*/
public function test_get_combined_document_for_attempt_rotates_image() {
public function test_get_combined_document_for_attempt_rotates_image(): void {
global $CFG, $DB;
$this->resetAfterTest();