L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-40264-m24-essay-zero' of git://github.com/ktemkin/moodle into MOODLE_24_STABLE

Browse Source
This commit is contained in:
Eloy Lafuente (stronk7)
2013-06-24 21:23:34 +02:00
parent 4207e4771a b64526c715
commit 1de08a0e60
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/essay/question.php
+1 -1
View File
@@ -82,7 +82,7 @@ class qtype_essay_question extends question_with_responses {
}
public function is_complete_response(array $response) {
return !empty($response['answer']);
return array_key_exists('answer', $response) && ($response['answer'] !== '');
}
public function is_same_response(array $prevresponse, array $newresponse) {
question/type/essay/tests/question_test.php
+15
View File
@@ -49,4 +49,19 @@ class qtype_essay_question_test extends advanced_testcase {
$this->assertEquals($longstring,
$essay->summarise_response(array('answer' => $longstring)));
}
public function test_is_complete_response() {
$essay = test_question_maker::make_an_essay_question();
$essay->start_attempt(new question_attempt_step(), 1);
// The empty string should be considered an empty response, as should a lack of a response.
$this->assertFalse($essay->is_complete_response(array('answer' => '')));
$this->assertFalse($essay->is_complete_response(array()));
// Any nonempty string should be considered a complete response.
$this->assertTrue($essay->is_complete_response(array('answer' => 'A student response.')));
$this->assertTrue($essay->is_complete_response(array('answer' => '0 times.')));
$this->assertTrue($essay->is_complete_response(array('answer' => '0')));
}
}