improved accessibility of user edit page - adding help icons, removing incorrect static help from interest, improving interests strings

lang/en_utf8/moodle.php

@@ -559,7 +559,6 @@ $string['enrolstartdate'] = 'Start date';
 $string['entercourse'] = 'Click to enter this course';
 $string['enteremailaddress'] = 'Enter in your email address to reset your
    password and have the new password sent to you via email.';
-$string['enteryourinterests'] = 'Enter your interests separated by commas';
 $string['entries'] = 'Entries';
 $string['error'] = 'Error';
 $string['errortoomanylogins'] = 'Sorry, you have exceeded the allowed number of login attempts. Restart your browser.';
@@ -720,6 +719,7 @@ $string['healthsolution'] = 'Solution';
 $string['help'] = 'Help';
 $string['helpemoticons'] = 'Use emoticons';
 $string['helpformatting'] = 'About formatting text';
+$string['helpinterestslist'] = 'Enter your interests separated by commas';
 $string['helphtml'] = 'How to write html';
 $string['helpindex'] = 'Index of all help files';
 $string['helppicture'] = 'How to upload a picture';
@@ -785,6 +785,7 @@ $string['info'] = 'Information';
 $string['institution'] = 'Institution';
 $string['instudentview'] = 'in student view';
 $string['interests'] = 'Interests';
+$string['interestslist'] = 'List of interests';
 $string['invalidemail'] = 'Invalid email address';
 $string['invalidlogin'] = 'Invalid login, please try again';
 $string['ip_address'] = 'IP Address';

user/editadvanced_form.php

@@ -33,11 +33,13 @@ class user_editadvanced_form extends moodleform {
         $mform->setAdvanced('auth');
 
         $mform->addElement('passwordunmask', 'newpassword', get_string('newpassword'), 'size="20"');
+        $mform->setHelpButton('newpassword', array(false, get_string('leavetokeep'),
+                          false, true, false, get_string('leavetokeep')));
         $mform->setType('newpassword', PARAM_RAW);
-        //TODO: add missing help - empty means no change
 
         $mform->addElement('advcheckbox', 'preference_auth_forcepasswordchange', get_string('forcepasswordchange'));
-        //TODO: add missing help - user will be forced to change password
+        $mform->setHelpButton('preference_auth_forcepasswordchange', array(false, get_string('forcepasswordchangehelp'),
+                          false, true, false, get_string('forcepasswordchangehelp')));
 
         /// shared fields
         useredit_shared_definition($mform);

user/editlib.php

@@ -223,8 +223,9 @@ function useredit_shared_definition(&$mform) {
 
     if( !empty($CFG->usetags)) {
         $mform->addElement('header', 'moodle_interests', get_string('interests'));
-        $mform->addElement('static', 'helptextinterests', '' , get_string('enteryourinterests'));
-        $mform->addElement('textarea', 'interests', get_string('interests'), 'cols="45" rows="3"');
+        $mform->addElement('textarea', 'interests', get_string('interestslist'), 'cols="45" rows="3"');
+        $mform->setHelpButton('interests', array(false, get_string('helpinterestslist'),
+                          false, true, false, get_string('helpinterestslist')));
     }
     
     /// Moodle optional fields