L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-83256 user: account for course context instances of teacher fields.

Browse Source
This commit is contained in:
Paul Holden
2025-08-18 08:56:56 +01:00
parent 2b96047622
commit 1bcfb780bb
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/user/profile/lib.php
+3
View File
@@ -472,7 +472,10 @@ class profile_field_base {
return true;
} else if ($this->userid > 0) {
return has_capability('moodle/user:viewalldetails', $context);
} else if ($context instanceof context_course) {
return has_capability('moodle/site:viewuseridentity', $context);
} else {
// Fall back to the global course object.
$coursecontext = context_course::instance($COURSE->id);
return has_capability('moodle/site:viewuseridentity', $coursecontext);
}
public/user/tests/fields_test.php
+1 -1
View File
@@ -104,7 +104,6 @@ final class fields_test extends \advanced_testcase {
// Give the student the basic identity fields permission (also makes them count as 'teacher'
// for the teacher-restricted field).
$COURSE = $course; // Horrible hack, because PROFILE_VISIBLE_TEACHERS relies on this global.
$roleid = $DB->get_field('role', 'id', ['shortname' => 'student']);
role_change_permission($roleid, $coursecontext, 'moodle/site:viewuseridentity', CAP_ALLOW);
$this->assertEquals(['department', 'profile_field_a', 'profile_field_d'],
@@ -132,6 +131,7 @@ final class fields_test extends \advanced_testcase {
$this->assertEquals([], fields::get_identity_fields($usercontext));
// Give them basic permission.
$COURSE = $course; // Horrible hack, because PROFILE_VISIBLE_TEACHERS relies on this global.
role_change_permission($roleid, $usercontext, 'moodle/site:viewuseridentity', CAP_ALLOW);
$this->assertEquals(['department', 'profile_field_a', 'profile_field_d'],
fields::get_identity_fields($usercontext));