L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-43326 Assign: Start new attempt from previous missing sesskey

Browse Source
This commit is contained in:
Damyon Wiese
2013-12-11 13:11:26 +08:00
parent dbc251e25c
commit 1ac6fd0322
3 changed files with 62 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/locallib.php
+1 -1
View File
@@ -5123,7 +5123,7 @@ class assign {
protected function process_copy_previous_attempt(&$notices) {
require_sesskey();
return copy_previous_attempt($notices);
return $this->copy_previous_attempt($notices);
}
/**
mod/assign/renderer.php
+3 -1
View File
@@ -685,7 +685,9 @@ class mod_assign_renderer extends plugin_renderer_base {
$o .= $this->output->box_end();
} else if ($submission->status == ASSIGN_SUBMISSION_STATUS_REOPENED) {
$o .= $this->output->box_start('generalbox submissionaction');
$urlparams = array('id' => $status->coursemoduleid, 'action' => 'editprevioussubmission');
$urlparams = array('id' => $status->coursemoduleid,
'action' => 'editprevioussubmission',
'sesskey'=>sesskey());
$o .= $this->output->single_button(new moodle_url('/mod/assign/view.php', $urlparams),
get_string('addnewattemptfromprevious', 'assign'), 'get');
$o .= $this->output->box_start('boxaligncenter submithelp');
mod/assign/tests/behat/allow_another_attempt.feature
+58
View File
@@ -0,0 +1,58 @@
@mod @mod_assign
Feature: In an assignment, students start a new attempt based on their previous one
In order to improve my submission
As a student
I need to submit my assignment editing an online form, receive feedback, and then improve my submission.
@javascript
Scenario: Submit a text online and edit the submission
Given the following "courses" exists:
| fullname | shortname | category | groupmode |
| Course 1 | C1 | 0 | 1 |
And the following "users" exists:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@asd.com |
| student1 | Student | 1 | student1@asd.com |
And the following "course enrolments" exists:
| user | course | role |
| teacher1 | C1 | editingteacher |
| student1 | C1 | student |
And I log in as "teacher1"
And I follow "Course 1"
And I turn editing mode on
And I add a "Assignment" to section "1" and I fill the form with:
| Assignment name | Test assignment name |
| Description | Submit your online text |
| assignsubmission_onlinetext_enabled | 1 |
| assignsubmission_file_enabled | 0 |
| Attempts reopened | Manually |
And I log out
And I log in as "student1"
And I follow "Course 1"
And I follow "Test assignment name"
When I press "Add submission"
And I fill the moodle form with:
| Online text | I'm the student first submission |
And I press "Save changes"
And I log out
And I log in as "teacher1"
And I follow "Course 1"
And I follow "Test assignment name"
And I follow "View/grade all submissions"
And I click on "Grade Student 1" "link" in the "Student 1" "table_row"
And I fill the moodle form with:
| Allow another attempt | 1 |
And I press "Save changes"
And I log out
And I log in as "student1"
And I follow "Course 1"
And I follow "Test assignment name"
And I press "Add a new attempt based on previous submission"
And I press "Save changes"
Then I log out
And I log in as "teacher1"
And I follow "Course 1"
And I follow "Test assignment name"
And I follow "View/grade all submissions"
And I click on "Grade Student 1" "link" in the "Student 1" "table_row"
And I should see "I'm the student first submission"