L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-76584 question: correct temporary questionid upgrade field.

Browse Source 
Pass correct parameter/type in field constructor (`XMLDB_NOTNULL`)
for consistency. This corrects the definition and preserves the
truthyness of the value that was incorrectly passed previously.
This commit is contained in:
Paul Holden
2023-01-23 09:16:39 +00:00
parent 8de12b7997
commit 1aa113fd1f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/db/upgrade.php
+2 -2
View File
@@ -2219,7 +2219,7 @@ privatefiles,moodle|/user/files.php';
// Creating temporary field questionid to populate the data in question version table.
// This will make sure the appropriate question id is inserted the version table without making any complex joins.
$table = new xmldb_table('question_bank_entries');
$field = new xmldb_field('questionid', XMLDB_TYPE_INTEGER, '10', null, XMLDB_TYPE_INTEGER);
$field = new xmldb_field('questionid', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL);
if (!$dbman->field_exists($table, $field)) {
$dbman->add_field($table, $field);
}
@@ -2268,7 +2268,7 @@ privatefiles,moodle|/user/files.php';
// Dropping temporary field questionid.
$table = new xmldb_table('question_bank_entries');
$field = new xmldb_field('questionid', XMLDB_TYPE_INTEGER, '10', null, XMLDB_TYPE_INTEGER);
$field = new xmldb_field('questionid', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL);
if ($dbman->field_exists($table, $field)) {
$dbman->drop_field($table, $field);
}