L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-55547 tool_monitor: Coding style fixes

Browse Source
This commit is contained in:
Andrew Nicols
2017-02-28 09:12:04 +08:00
parent 12ec6228a5
commit 188892a7a8
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/monitor/classes/subscription_manager.php
+2 -2
View File
@@ -234,9 +234,9 @@ class subscription_manager {
global $DB;
// Store all the subscriptions we have to delete.
if ($subscriptions = $DB->get_records('tool_monitor_subscriptions', array('courseid' => $coursecontext->instanceid))) {
if ($subscriptions = $DB->get_records('tool_monitor_subscriptions', ['courseid' => $coursecontext->instanceid])) {
// Delete subscriptions in bulk.
$DB->delete_records('tool_monitor_subscriptions', array('courseid' => $coursecontext->instanceid));
$DB->delete_records('tool_monitor_subscriptions', ['courseid' => $coursecontext->instanceid]);
// Trigger events one by one.
foreach ($subscriptions as $subscription) {
admin/tool/monitor/db/upgrade.php
+5 -4
View File
@@ -80,10 +80,11 @@ function xmldb_tool_monitor_upgrade($oldversion) {
if ($oldversion < 2016052306) {
// Delete "orphaned" subscriptions.
$deletedcourses = $DB->get_field_sql("SELECT DISTINCT s.courseid
FROM {tool_monitor_subscriptions} s
LEFT OUTER JOIN {course} c ON c.id = s.courseid
WHERE s.courseid <> 0 and c.id IS NULL");
$sql = "SELECT DISTINCT s.courseid
FROM {tool_monitor_subscriptions} s
LEFT OUTER JOIN {course} c ON c.id = s.courseid
WHERE s.courseid <> 0 and c.id IS NULL";
$deletedcourses = $DB->get_field_sql($sql);
if ($deletedcourses) {
list($sql, $params) = $DB->get_in_or_equal($deletedcourses);
$DB->execute("DELETE FROM {tool_monitor_subscriptions} WHERE courseid " . $sql, $params);