L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Renamed converter factory method to more self-descriptive get_converter()

Browse Source
This commit is contained in:
David Mudrak
2011-05-13 12:06:10 +02:00
parent 1cc0e42a86
commit 17d2e210b7
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backup/converter/moodle1/simpletest/testlib.php
+6 -6
View File
@@ -59,18 +59,18 @@ class moodle1_converter_test extends UnitTestCase {
}
public function test_convert_factory() {
$converter = convert_factory::converter('moodle1', $this->tempdir);
$converter = convert_factory::get_converter('moodle1', $this->tempdir);
$this->assertIsA($converter, 'moodle1_converter');
}
public function test_stash_storage_not_created() {
$converter = convert_factory::converter('moodle1', $this->tempdir);
$converter = convert_factory::get_converter('moodle1', $this->tempdir);
$this->expectException('moodle1_convert_storage_exception');
$converter->set_stash('tempinfo', 12);
}
public function test_stash_requiring_empty_stash() {
$converter = convert_factory::converter('moodle1', $this->tempdir);
$converter = convert_factory::get_converter('moodle1', $this->tempdir);
$converter->create_stash_storage();
$converter->set_stash('tempinfo', 12);
$this->expectException('moodle1_convert_empty_storage_exception');
@@ -85,7 +85,7 @@ class moodle1_converter_test extends UnitTestCase {
}
public function test_stash_storage() {
$converter = convert_factory::converter('moodle1', $this->tempdir);
$converter = convert_factory::get_converter('moodle1', $this->tempdir);
$converter->create_stash_storage();
// test stashes without itemid
@@ -112,7 +112,7 @@ class moodle1_converter_test extends UnitTestCase {
}
public function test_get_contextid() {
$converter = convert_factory::converter('moodle1', $this->tempdir);
$converter = convert_factory::get_converter('moodle1', $this->tempdir);
// stash storage must be created in advance
$converter->create_stash_storage();
@@ -135,7 +135,7 @@ class moodle1_converter_test extends UnitTestCase {
}
public function test_convert_run_convert() {
$converter = convert_factory::converter('moodle1', $this->tempdir);
$converter = convert_factory::get_converter('moodle1', $this->tempdir);
$converter->convert();
}
}
backup/util/factories/convert_factory.class.php
+1 -1
View File
@@ -37,7 +37,7 @@ abstract class convert_factory {
* @param $tempdir The temp directory to operate on
* @return base_converter
*/
public static function converter($name, $tempdir) {
public static function get_converter($name, $tempdir) {
global $CFG;
$name = clean_param($name, PARAM_SAFEDIR);
backup/util/helper/convert_helper.class.php
+1 -1
View File
@@ -143,7 +143,7 @@ abstract class convert_helper {
}
foreach ($path as $name) {
$converter = convert_factory::converter($name, $tempdir);
$converter = convert_factory::get_converter($name, $tempdir);
$converter->convert();
}