L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-47927 LTI: Use PARAM_TEXT and p() for returned messages and errors

Browse Source
This commit is contained in:
Damyon Wiese
2014-11-04 11:48:24 +13:00
committed by Sam Hemelryk
parent 1d9e0857f8
commit 15bde5352b
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lti/locallib.php
+4 -1
View File
@@ -154,7 +154,10 @@ function lti_view($instance) {
$requestparams = lti_build_request($instance, $typeconfig, $course);
$launchcontainer = lti_get_launch_container($instance, $typeconfig);
$returnurlparams = array('course' => $course->id, 'launch_container' => $launchcontainer, 'instanceid' => $instance->id);
$returnurlparams = array('course' => $course->id,
'launch_container' => $launchcontainer,
'instanceid' => $instance->id,
'sesskey' => sesskey());
if ( $orgid ) {
$requestparams["tool_consumer_instance_guid"] = $orgid;
mod/lti/return.php
+3 -2
View File
@@ -31,7 +31,7 @@ require_once($CFG->dirroot.'/mod/lti/locallib.php');
$courseid = required_param('course', PARAM_INT);
$instanceid = required_param('instanceid', PARAM_INT);
$errormsg = optional_param('lti_errormsg', '', PARAM_RAW);
$errormsg = optional_param('lti_errormsg', '', PARAM_TEXT);
$unsigned = optional_param('unsigned', '0', PARAM_INT);
$launchcontainer = optional_param('launch_container', LTI_LAUNCH_CONTAINER_WINDOW, PARAM_INT);
@@ -39,6 +39,7 @@ $launchcontainer = optional_param('launch_container', LTI_LAUNCH_CONTAINER_WINDO
$course = $DB->get_record('course', array('id' => $courseid));
require_login($course);
require_sesskey();
if (!empty($errormsg)) {
$url = new moodle_url('/mod/lti/return.php', array('course' => $courseid));
@@ -59,7 +60,7 @@ if (!empty($errormsg)) {
echo get_string('lti_launch_error', 'lti');
echo htmlspecialchars($errormsg);
p($errormsg);
if ($unsigned == 1) {