L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-65313 core: fix deletion of group conversation favourites

Browse Source 
This now requires itemid, which cannot be null. This is safer. The
context is still used an an additional filter.
This commit is contained in:
Jake Dallimore
2019-05-07 11:03:28 +08:00
parent 391d53f871
commit 151fc538de
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
group/lib.php
+4 -3
View File
@@ -575,9 +575,10 @@ function groups_delete_group($grouporid) {
// Delete all favourite records for all users relating to this conversation.
// Whilst not ideal, we can't use the component service as it doesn't exist here, so must do this manually.
$params = ['component' => 'core_message', 'itemtype' => 'message_conversations', 'contextid' => $conversation->contextid];
$DB->delete_records_select('favourite', ' component = :component AND itemtype = :itemtype AND contextid = :contextid',
$params);
$params = ['component' => 'core_message', 'itemtype' => 'message_conversations', 'itemid' => $conversation->id,
'contextid' => $conversation->contextid];
$select = ' component = :component AND itemtype = :itemtype AND itemid = :itemid AND contextid = :contextid';
$DB->delete_records_select('favourite', $select, $params);
}
//group itself last