MDL-38173 Course: Use the correct module id's when adding to a section
When course completion is on, $mod->id is the instance, not the course_module id. In add_to_section $mod->coursemodule must be used.
This commit is contained in:
committed by
Damyon Wiese
parent
8a7bc6c3d8
commit
14c2bada33
+2
-2
@@ -2848,7 +2848,7 @@ function add_mod_to_section($mod, $beforemod=NULL) {
|
||||
}
|
||||
|
||||
$DB->set_field("course_sections", "sequence", $newsequence, array("id"=>$section->id));
|
||||
$DB->set_field("course_modules", "section", $section->id, array("id" => $mod->id));
|
||||
$DB->set_field("course_modules", "section", $section->id, array("id" => $mod->coursemodule));
|
||||
return $section->id; // Return course_sections ID that was used.
|
||||
|
||||
} else { // Insert a new record
|
||||
@@ -2859,7 +2859,7 @@ function add_mod_to_section($mod, $beforemod=NULL) {
|
||||
$section->summaryformat = FORMAT_HTML;
|
||||
$section->sequence = $mod->coursemodule;
|
||||
$section->id = $DB->insert_record("course_sections", $section);
|
||||
$DB->set_field("course_modules", "section", $section->id, array("id" => $mod->id));
|
||||
$DB->set_field("course_modules", "section", $section->id, array("id" => $mod->coursemodule));
|
||||
return $section->id;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user