L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-47494 ddimageortext: MDL-45111 quiz responses report : fatal error when counting responses

Browse Source 
not all possible responses where returned by question type method.
This commit is contained in:
James Pratt
2014-04-18 19:40:50 +07:00
parent 864d36c939
commit 13ee9a2639
2 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/ddimageortext/questionbase.php
+6 -2
View File
@@ -122,8 +122,12 @@ class qtype_ddtoimage_question_base extends qtype_gapselect_question_base {
$choice = $this->choices[$group][$choiceno];
$correct = $this->get_right_choice_for($placeno) == $response[$fieldname];
$parts[$placeno] = new question_classified_response(
$choiceno, $choice->summarise(), $correct?1:0);
if ($correct) {
$grade = 1;
} else {
$grade = 0;
}
$parts[$placeno] = new question_classified_response($choiceno, $choice->summarise(), $grade);
}
return $parts;
}
question/type/ddimageortext/questiontypebase.php
+3 -10
View File
@@ -60,7 +60,7 @@ class qtype_ddtoimage_base extends question_type {
$this->initialise_combined_feedback($question, $questiondata, true);
$question->choices = array();
$choiceindexmap= array();
$choiceindexmap = array();
// Store the choices in arrays by group.
foreach ($questiondata->options->drags as $dragdata) {
@@ -165,18 +165,11 @@ class qtype_ddtoimage_base extends question_type {
$parts = array();
foreach ($question->places as $placeno => $place) {
$group = $place->group;
$choices = array();
foreach ($question->choices[$group] as $i => $choice) {
$summarisechoice = $choice->summarise();
foreach ($question->choices[$place->group] as $i => $choice) {
$correct = $question->rightchoices[$placeno] == $i;
if ($correct) {
$choices[$choice->no] = new question_possible_response(
$summarisechoice,
$correct?1:0);
}
$choices[$choice->no] = new question_possible_response($choice->summarise(), $correct ? 1 : 0);
}
$choices[null] = question_possible_response::no_response();