L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-56893 grades: Fix edit grade item when grade_report_showmin is false

Browse Source 
Check to make sure $data['grademin'] exists. When grade_report_showmin
is false $data['grademin'] doesn't exist.
This commit is contained in:
Michael Spall
2016-11-30 12:07:14 -07:00
parent 67b81de806
commit 13cba568ff
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/edit/tree/item_form.php
+2 -1
View File
@@ -463,7 +463,8 @@ class edit_item_form extends moodleform {
}
if ($grade_item) {
if ($grade_item->gradetype == GRADE_TYPE_VALUE) {
if (grade_floats_different($data['grademin'], $grade_item->grademin) ||
if ((((bool) get_config('moodle', 'grade_report_showmin')) &&
grade_floats_different($data['grademin'], $grade_item->grademin)) ||
grade_floats_different($data['grademax'], $grade_item->grademax)) {
if ($grade_item->has_grades() && empty($data['rescalegrades'])) {
$errors['rescalegrades'] = get_string('mustchooserescaleyesorno', 'grades');