L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-27619: Prevent teachers from turning course Outcomes into site-wide ones

Browse Source 
Similar to the issue which allowed teachers to create site-wide scales by editing a course-specific scale (MDL-24682), teachers could also promote a course-specific scale to a site-wide (standard) by editing it.  As with MDL-24682, removing the course ID check (leaving just the capability check) prevents this unauthorised creation of site-wide (standard) outcomes.
This commit is contained in:
Paul Nicholls
2012-11-27 09:48:16 +13:00
parent 5f1d8f2a8f
commit 134ede3476
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/edit/outcome/edit_form.php
+1 -1
View File
@@ -121,7 +121,7 @@ class edit_outcome_form extends moodleform {
if (empty($courseid)) {
$mform->hardFreeze('standard');
} else if (empty($outcome->courseid) and !has_capability('moodle/grade:manage', get_context_instance(CONTEXT_SYSTEM))) {
} else if (!has_capability('moodle/grade:manage', get_context_instance(CONTEXT_SYSTEM))) {
$mform->hardFreeze('standard');
} else if ($coursecount and empty($outcome->courseid)) {