Fixed a PHP bug in deleting assignment instances. (SE).

mod/assignment/lib.php

@@ -337,10 +337,7 @@ class assignment_base {
     }
 
     function delete_instance($assignment) {
-        if (! delete_records("assignment", "id", "$assignment->id")) {
-            $result = false;
-        }
-        return $result;
+        return delete_records('assignment', 'id', $assignment->id);
     }
 
     function update_instance($assignment) {

mod/assignment/styles.php

@@ -34,8 +34,8 @@
   margin-right: 4px;
 }
 
-.mod-assignment .files {
-  whitespace:nowrap;
+.mod-assignment .files a {
+  white-space:nowrap;
 }
 
 #mod-assignment-submissions .generaltable .r1 {

mod/assignment/view.php

@@ -6,9 +6,8 @@
     $id = optional_param('id');    // Course Module ID
     $a  = optional_param('a');
 
-    if (!empty($CFG->forcelogin)) {
-        require_login();
-    }
+    $db->debug = true;
+
 
     if ($id) {
         if (! $cm = get_record("course_modules", "id", $id)) {
@@ -34,6 +33,8 @@
         }
     }
 
+    require_login($course->id);
+
     require ("$CFG->dirroot/mod/assignment/type/$assignment->assignmenttype/assignment.class.php");
     $assignmentclass = "assignment_$assignment->assignmenttype";
     $assignmentinstance = new $assignmentclass($cm->id, $assignment, $cm, $course);