Merge branch 'MDL-49551_master' of git://github.com/markn86/moodle

lib/dml/moodle_database.php

@@ -1083,11 +1083,13 @@ abstract class moodle_database {
 
     /**
      * Enable/disable detailed sql logging
+     *
+     * @deprecated since Moodle 2.9
+     * @todo MDL-49824 This will be deleted in Moodle 3.1.
      * @param bool $state
      */
     public function set_logging($state) {
-        // adodb sql logging shares one table without prefix per db - this is no longer acceptable :-(
-        // we must create one table shared by all drivers
+        debugging('set_logging() is deprecated and will not be replaced.', DEBUG_DEVELOPER);
     }
 
     /**

lib/dml/tests/dml_test.php

@@ -5418,7 +5418,6 @@ class moodle_database_for_testing extends moodle_database {
     protected function normalise_value($column, $value) {}
     public function set_debug($state) {}
     public function get_debug() {}
-    public function set_logging($state) {}
     public function change_database_structure($sql) {}
     public function execute($sql, array $params=null) {}
     public function get_recordset_sql($sql, array $params=null, $limitfrom=0, $limitnum=0) {}