MDL-22386 merge from HEAD setting correctly the number of dataitem when duplicating a calculated, calculatedsimple, calculatedmulti question

2010-05-07 22:08:27 +00:00
parent 13e949cdb0
commit 0fc550a5cc
1 changed files with 7 additions and 2 deletions
@@ -468,8 +468,13 @@ class question_dataset_dependent_questiontype extends default_questiontype {
                        }
                        $itemcount++;
                        }
-                        //update item count
-                        $datasetdef->itemcount =$itemcount;
+                        //update item count to olditemcount if 
+                        // at least this number of items has been recover from the database
+                        if( $olditemcount <= $itemcount ) {
+                            $datasetdef->itemcount = $olditemcount;
+                        } else {
+                            $datasetdef->itemcount = $itemcount ;
+                        }
                        update_record('question_dataset_definitions', $datasetdef);
                    } // end of  copy the dataitems
                }// end of  copy the datasetdef