L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-21178 formslib element modgrade does not use deprecated link_to_popup_window() for help icon

Browse Source
This commit is contained in:
David Mudrak
2009-12-23 16:54:39 +00:00
parent e0738f5778
commit 0ea95ddcb7
2 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/form/modgrade.php
+1 -3
View File
@@ -62,9 +62,7 @@ class MoodleQuickForm_modgrade extends MoodleQuickForm_select{
$grades[$i] = $i;
}
$this->load($grades);
$linkobject = '<span class="helplink"><img height="17" width="17" alt="'.$strscales.'" src="'.$OUTPUT->pix_url('help') . '" /></span>';
$this->setHelpButton(array('/course/scales.php?id='. $COURSE->id .'&amp;list=true', 'ratingscales',
$linkobject, 400, 500, $strscales, 'none', true), 'link_to_popup_window');
$this->setHelpButton(array($COURSE->id), 'modgradehelpbutton');
return $result;
}
return parent::onQuickFormEvent($event, $arg, $caller);
lib/weblib.php
+21
View File
@@ -2710,6 +2710,27 @@ function editorshortcutshelpbutton() {
return '';
}
/**
* Returns html code to be used as help icon of modgrade form element
*
* Is used as a callback in modgrade setHelpButton()
*
* @param int $courseid id of the course the scales should be shown from
* @return string to be echoed
*/
function modgradehelpbutton($courseid){
global $CFG, $OUTPUT;
$url = new moodle_url($CFG->wwwroot .'/course/scales.php', array('id' => $courseid, 'list' => true));
$link = new html_link();
$link->url = $url;
$link->text = '<span class="helplink"><img alt="' . get_string('scales') . '" class="iconhelp" src="' . $OUTPUT->pix_url('help') . '" /></span>';
$link->add_action(new popup_action('click', $link->url, 'ratingscales', array('height' => 400, 'width' => 500)));
$link->title = get_string('newwindow');
return $OUTPUT->link($link);
}
/**
* Print a message and exit.
*