MDL-64588 core_comment: fix unnecessary type check in add_comments

We should rely on the return type, else an exception with be thrown.
2019-10-02 09:23:43 +08:00
parent 93ea6612bd
commit 0c3eaf9ee6
1 changed files with 1 additions and 3 deletions
@@ -254,10 +254,8 @@ class core_comment_external extends external_api {
        foreach ($params['comments'] as $comment) {
            $manager = $comment['preparedcomment'];
            $newcomment = $manager->add($comment['content']);
-            if (!empty($newcomment) && is_object($newcomment)) {
-                $results[] = $newcomment;
-            }
            $newcomment->delete = true; // USER created the comment, so they can delete it.
+            $results[] = $newcomment;
        }

        return $results;