L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-43398 Wiki: Choose... options cause SQL errors or seen inappropriate.

Browse Source
This commit is contained in:
Jerome Mouneyrac
2014-03-27 14:52:31 +08:00
committed by Marina Glancy
parent c7d46f034c
commit 07470deddb
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/wiki/pagelib.php
+1 -4
View File
@@ -1427,14 +1427,11 @@ class page_wiki_map extends page_wiki {
echo $this->wikioutput->menu_map($this->page->id, $this->view);
$this->print_index_content();
break;
case 5:
echo $this->wikioutput->menu_map($this->page->id, $this->view);
$this->print_page_list_content();
break;
case 6:
echo $this->wikioutput->menu_map($this->page->id, $this->view);
$this->print_updated_content();
break;
case 5:
default:
echo $this->wikioutput->menu_map($this->page->id, $this->view);
$this->print_page_list_content();
mod/wiki/renderer.php
+8 -4
View File
@@ -344,7 +344,7 @@ class mod_wiki_renderer extends plugin_renderer_base {
$baseurl->params($params);
$name = 'uid';
$selected = $subwiki->userid;
echo $this->output->single_select($baseurl, $name, $options, $selected);
echo $this->output->single_select($baseurl, $name, $options, $selected, null);
echo $this->output->container_end();
}
return;
@@ -404,7 +404,7 @@ class mod_wiki_renderer extends plugin_renderer_base {
$baseurl->params($params);
$name = 'groupanduser';
$selected = $subwiki->groupid . '-' . $subwiki->userid;
echo $this->output->single_select($baseurl, $name, $options, $selected);
echo $this->output->single_select($baseurl, $name, $options, $selected, null);
echo $this->output->container_end();
return;
@@ -451,7 +451,7 @@ class mod_wiki_renderer extends plugin_renderer_base {
$baseurl->params($params);
$name = 'groupanduser';
$selected = $subwiki->groupid . '-' . $subwiki->userid;
echo $this->output->single_select($baseurl, $name, $options, $selected);
echo $this->output->single_select($baseurl, $name, $options, $selected, null);
echo $this->output->container_end();
return;
@@ -469,6 +469,10 @@ class mod_wiki_renderer extends plugin_renderer_base {
}
function menu_map($pageid, $currentselect) {
if (empty($currentselect)) {
// The wiki uses digit number to match the options and 5 is the default one.
$currentselect = 5;
}
$options = array('contributions', 'links', 'orphaned', 'pageindex', 'pagelist', 'updatedpages');
$items = array();
foreach ($options as $opt) {
@@ -509,7 +513,7 @@ class mod_wiki_renderer extends plugin_renderer_base {
foreach ($items as $key => $item) {
$selectoptions[$key + 1] = $item;
}
$select = new single_select(new moodle_url('/mod/wiki/admin.php', array('pageid' => $pageid)), 'option', $selectoptions, $currentselect);
$select = new single_select(new moodle_url('/mod/wiki/admin.php', array('pageid' => $pageid)), 'option', $selectoptions, $currentselect, null);
$select->label = get_string('adminmenu', 'wiki') . ': ';
return $this->output->container($this->output->render($select), 'midpad');
}