L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-71694 assignfeedback_comments: Fill latest submitted comment data

Browse Source 
Otherwise if grading validation fails, any new/updated comments are
lost and replaced with previously saved data (or an empty editor).
This commit is contained in:
Tony Butler
2021-06-24 12:03:02 +08:00
committed by Andrew Nicols
parent 3cb27b509e
commit 0474ebc970
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/feedback/comments/locallib.php
+5 -1
View File
@@ -348,7 +348,11 @@ class assign_feedback_comments extends assign_feedback_plugin {
$feedbackcomments = $this->get_feedback_comments($grade->id);
}
if ($feedbackcomments && !empty($feedbackcomments->commenttext)) {
// Check first for data from last form submission in case grading validation failed.
if (!empty($data->assignfeedbackcomments_editor['text'])) {
$data->assignfeedbackcomments = $data->assignfeedbackcomments_editor['text'];
$data->assignfeedbackcommentsformat = $data->assignfeedbackcomments_editor['format'];
} else if ($feedbackcomments && !empty($feedbackcomments->commenttext)) {
$data->assignfeedbackcomments = $feedbackcomments->commenttext;
$data->assignfeedbackcommentsformat = $feedbackcomments->commentformat;
} else {