L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-67683 theme: Do not use section for block containers

Browse Source 
The containers for the blocks in layout templates should not be using a
<section> tag (which has a default landmark role of "region") as the
blocks are already contained in an <aside> tag that has the default
"complementary" role which should be a top-level landmark.

Read more at:
https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
This commit is contained in:
Jun Pataleta
2025-02-03 15:55:22 +08:00
parent b44acfecd2
commit 03adce20fc
6 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
theme/boost/templates/columns2.mustache
+2 -2
View File
@@ -91,10 +91,10 @@
</div>
{{#hasblocks}}
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
<div data-region="blocks-column" class="d-print-none">
{{{ addblockbutton }}}
{{{ sidepreblocks }}}
</section>
</div>
{{/hasblocks}}
</div>
</div>
theme/boost/templates/drawers.mustache
+2 -2
View File
@@ -79,10 +79,10 @@
{{$id}}theme_boost-drawers-blocks{{/id}}
{{$drawerclasses}}drawer drawer-right{{#blockdraweropen}} show{{/blockdraweropen}}{{/drawerclasses}}
{{$drawercontent}}
<section class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
<div class="d-print-none">
{{{ addblockbutton }}}
{{{ sidepreblocks }}}
</section>
</div>
{{/drawercontent}}
{{$drawerpreferencename}}drawer-open-block{{/drawerpreferencename}}
{{$forceopen}}{{#forceblockdraweropen}}1{{/forceblockdraweropen}}{{/forceopen}}
theme/boost/templates/embedded.mustache
+2 -2
View File
@@ -56,9 +56,9 @@
{{{ output.standard_top_of_body_html }}}
<div id="page" {{#hasfakeblocks}}class="has-fake-blocks"{{/hasfakeblocks}}>
{{#hasfakeblocks}}
<section class="embedded-blocks" aria-label="{{#str}}blocks{{/str}}">
<div class="embedded-blocks">
{{{ fakeblocks }}}
</section>
</div>
{{/hasfakeblocks}}
<section class="embedded-main">
{{#headercontent}}
theme/boost/templates/secure.mustache
+2 -2
View File
@@ -71,9 +71,9 @@
</div>
{{#hasblocks}}
<section data-region="blocks-column" aria-label="{{#str}}blocks{{/str}}">
<div data-region="blocks-column">
{{{ sidepreblocks }}}
</section>
</div>
{{/hasblocks}}
</div>
</div>
theme/classic/templates/columns.mustache
+4 -4
View File
@@ -80,15 +80,15 @@
</div>
</div>
<div class="columnleft blockcolumn {{#haspreblocks}} has-blocks {{/haspreblocks}}">
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
<div data-region="blocks-column" class="d-print-none">
{{{ sidepreblocks }}}
</section>
</div>
</div>
<div class="columnright blockcolumn {{#haspostblocks}} has-blocks {{/haspostblocks}}">
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
<div data-region="blocks-column" class="d-print-none">
{{{ sidepostblocks }}}
</section>
</div>
</div>
</div>
</div>
theme/classic/templates/secure.mustache
+4 -4
View File
@@ -85,15 +85,15 @@
</div>
</div>
<div class="columnleft {{#haspreblocks}} has-blocks {{/haspreblocks}}">
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
<div data-region="blocks-column" class="d-print-none">
{{{ sidepreblocks }}}
</section>
</div>
</div>
<div class="columnright {{#haspostblocks}} has-blocks {{/haspostblocks}}">
<section data-region="blocks-column" class="d-print-none" aria-label="{{#str}}blocks{{/str}}">
<div data-region="blocks-column" class="d-print-none">
{{{ sidepostblocks }}}
</section>
</div>
</div>
</div>
</div>