MDL-28580 Administration: Added sanity check to grab wrong usage of upgrade_main_savepoint

2011-08-19 07:41:13 +00:00
parent 24654d977b
commit 01f9bc7948
1 changed files with 6 additions and 0 deletions
@@ -114,6 +114,12 @@ class plugin_defective_exception extends moodle_exception {
 function upgrade_main_savepoint($result, $version, $allowabort=true) {
    global $CFG;

+    //sanity check to avoid confusion with upgrade_mod_savepoint usage.
+    if (!is_bool($allowabort)) {
+        $errormessage = 'Parameter type mismatch. Are you mixing up upgrade_main_savepoint() and upgrade_mod_savepoint()?';
+        throw new coding_exception($errormessage);
+    }
+
    if (!$result) {
        throw new upgrade_exception(null, $version);
    }