Compare commits

...

2 Commits

Author SHA1 Message Date
Jagrit Digani 12f766efe9 Fix edge checking in attention mask 2026-01-15 14:10:24 -08:00
Jagrit Digani 097abca156 Fix edge checking in attention mask 2026-01-15 14:05:54 -08:00
@@ -349,14 +349,20 @@ template <
const short col_pos = base_col + ik * UK + sn;
MSubTile mfrag;
mfrag.load_safe(
mask,
int64_t(mask_params->M_strides[2]),
Int<1>{},
params->qL,
params->kL,
row_pos,
col_pos);
if ((!align_Q && is_last_q) || (!align_K && is_last_k)) {
mfrag.load_safe(
mask,
int64_t(mask_params->M_strides[2]),
Int<1>{},
params->qL,
params->kL,
row_pos,
col_pos);
} else {
const int M_str = int(mask_params->M_strides[2]);
const int M_load_off = row_pos * M_str + col_pos;
mfrag.load(mask + M_load_off, M_str, Int<1>{});
}
thread auto& fg = Ptile.subtile_at(iq, ik).frag_at(0, 0);