replace MLX_IBV_COORDINATOR with MLX_JACCL_COORDINATOR (#2986)
This commit is contained in:
@@ -584,7 +584,7 @@ the process.
|
||||
**MLX_JACCL_COORDINATOR** should contain the IP and port that rank 0 can listen
|
||||
to all the other ranks connect to in order to establish the RDMA connections.
|
||||
|
||||
**MLX_IBV_DEVICES** should contain the path to a json file that contains the
|
||||
**MLX_JACCL_DEVICES** should contain the path to a json file that contains the
|
||||
ibverbs device names that connect each node to each other node, something like
|
||||
the following:
|
||||
|
||||
|
||||
@@ -1159,7 +1159,7 @@ bool is_available() {
|
||||
}
|
||||
|
||||
std::shared_ptr<GroupImpl> init(bool strict /* = false */) {
|
||||
const char* dev_file = std::getenv("MLX_IBV_DEVICES");
|
||||
const char* dev_file = std::getenv("MLX_JACCL_DEVICES");
|
||||
const char* coordinator = std::getenv("MLX_JACCL_COORDINATOR");
|
||||
const char* rank_str = std::getenv("MLX_RANK");
|
||||
|
||||
@@ -1167,9 +1167,9 @@ std::shared_ptr<GroupImpl> init(bool strict /* = false */) {
|
||||
if (strict) {
|
||||
std::ostringstream msg;
|
||||
msg << "[jaccl] You need to provide via environment variables a rank (MLX_RANK), "
|
||||
<< "a device file (MLX_IBV_DEVICES) and a coordinator ip/port (MLX_JACCL_COORDINATOR) "
|
||||
<< "a device file (MLX_JACCL_DEVICES) and a coordinator ip/port (MLX_JACCL_COORDINATOR) "
|
||||
<< "but provided MLX_RANK=\"" << ((rank_str) ? rank_str : "")
|
||||
<< "\", MLX_IBV_DEVICES=\"" << ((dev_file) ? dev_file : "")
|
||||
<< "\", MLX_JACCL_DEVICES=\"" << ((dev_file) ? dev_file : "")
|
||||
<< "\" and MLX_JACCL_COORDINATOR=\""
|
||||
<< ((coordinator) ? coordinator : "");
|
||||
throw std::runtime_error(msg.str());
|
||||
|
||||
@@ -376,7 +376,7 @@ def launch_jaccl(parser, hosts, args, command):
|
||||
env = args.env
|
||||
cwd = args.cwd
|
||||
env.append(f"MLX_JACCL_COORDINATOR={coordinator}:{args.starting_port}")
|
||||
files = {"MLX_IBV_DEVICES": json.dumps([h.rdma for h in hosts])}
|
||||
files = {"MLX_JACCL_DEVICES": json.dumps([h.rdma for h in hosts])}
|
||||
|
||||
log(args.verbose, "Running", shlex.join(command))
|
||||
|
||||
|
||||
Reference in New Issue
Block a user