From 7c1624cfaa3c09ed83f4d12e81deddf2f4bf3b5f Mon Sep 17 00:00:00 2001 From: leo <260626284+cameledev@users.noreply.github.com> Date: Tue, 24 Mar 2026 17:23:45 +0100 Subject: [PATCH] modify metadata recording conditions --- src/agents/metadata_collector.py | 5 +---- src/backend/core/api/viewsets.py | 6 +----- src/backend/core/services/livekit_events.py | 3 +-- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/agents/metadata_collector.py b/src/agents/metadata_collector.py index bee1ef8e..471f4b38 100644 --- a/src/agents/metadata_collector.py +++ b/src/agents/metadata_collector.py @@ -178,10 +178,7 @@ class MetadataCollector: def save(self): """Serialize collected events and upload as JSON to S3.""" - scheme = "https" if os.getenv("AWS_S3_SECURE_ACCESS", "False").lower() == "true" else "http" - endpoint = os.getenv("AWS_S3_ENDPOINT_URL", "") - url = f"{scheme}://{endpoint}/{self.bucket_name}/{self.output_filename}" - logger.info("Persisting metadata to %s", url) + logger.info("Persisting metadata...") participants = [] for k, v in self.participants.items(): diff --git a/src/backend/core/api/viewsets.py b/src/backend/core/api/viewsets.py index 2fac179f..86879c87 100644 --- a/src/backend/core/api/viewsets.py +++ b/src/backend/core/api/viewsets.py @@ -340,11 +340,7 @@ class RoomViewSet( status=drf_status.HTTP_500_INTERNAL_SERVER_ERROR, ) - - if ( - settings.METADATA_COLLECTOR_ENABLED - and recording.mode == models.RecordingModeChoices.TRANSCRIPT - ): + if settings.METADATA_COLLECTOR_ENABLED and recording.options.transcribe: try: MetadataCollectorService().start(recording) except MetadataCollectorException: diff --git a/src/backend/core/services/livekit_events.py b/src/backend/core/services/livekit_events.py index 46abb6c6..0d2a588f 100644 --- a/src/backend/core/services/livekit_events.py +++ b/src/backend/core/services/livekit_events.py @@ -178,10 +178,9 @@ class LiveKitEventsService: except utils.MetadataUpdateException as e: logger.exception("Failed to update room's metadata: %s", e) - if ( settings.METADATA_COLLECTOR_ENABLED - and recording.mode == models.RecordingModeChoices.TRANSCRIPT + and recording.options.get("metadata_collector_dispatch_id") ): try: MetadataCollectorService().stop(recording)