From 4c5e8e65aae48830c8034e7b5c360a3210039950 Mon Sep 17 00:00:00 2001
From: bhushan6 <bhushanwagh6@gmail.com>
Date: Tue, 15 Aug 2023 03:51:16 +0530
Subject: [PATCH] fixes unsynced position of outline

---
 src/components/3D/BrickOutline.jsx       | 15 ++++++++-------
 src/components/UI/Panel/Slider/index.jsx |  2 +-
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/components/3D/BrickOutline.jsx b/src/components/3D/BrickOutline.jsx
index 355f1e3..4a8abdc 100644
--- a/src/components/3D/BrickOutline.jsx
+++ b/src/components/3D/BrickOutline.jsx
@@ -34,15 +34,15 @@ const OutlineMesh = ({ meshesData }) => {
     });
   }, [width, height, depth, dimensions]);
 
-  const compansate = {
-    x: dimensions.x % 2 === 0 ? dimensions.x / 2 : (dimensions.x - 1) / 2,
-    z: dimensions.z % 2 === 0 ? dimensions.z / 2 : (dimensions.z - 1) / 2,
-  };
-
   useLayoutEffect(() => {
     if (!ref.current) return;
 
     meshesData.forEach((meshData, i) => {
+      const compansate = {
+        x: dimensions.x % 2 === 0 ? dimensions.x / 2 : (dimensions.x - 1) / 2,
+        z: dimensions.z % 2 === 0 ? dimensions.z / 2 : (dimensions.z - 1) / 2,
+      };
+
       const translation = meshData.translation;
 
       const offset = {
@@ -58,9 +58,9 @@ const OutlineMesh = ({ meshesData }) => {
 
       dummy.rotation.set(0, meshData.rotation, 0);
       dummy.position.set(
-        meshData.position.x + offset.x,
+        meshData.position.x + (offset.x * width) / dimensions.x,
         Math.abs(meshData.position.y),
-        meshData.position.z + offset.z
+        meshData.position.z + (offset.z * width) / dimensions.z
       );
       dummy.updateMatrix();
       ref.current.setMatrixAt(i, dummy.matrix);
@@ -74,6 +74,7 @@ const OutlineMesh = ({ meshesData }) => {
         ref={ref}
         position={[0, 0.5, 0]}
         args={[outlineGeometry, null, meshesData.length]}
+        raycast={() => {}}
       >
         <meshBasicMaterial color={"white"} side={BackSide} />
       </instancedMesh>
diff --git a/src/components/UI/Panel/Slider/index.jsx b/src/components/UI/Panel/Slider/index.jsx
index 93f40b8..3698f5b 100644
--- a/src/components/UI/Panel/Slider/index.jsx
+++ b/src/components/UI/Panel/Slider/index.jsx
@@ -36,7 +36,7 @@ export const SliderWithLabel = ({
         max={4}
         step={1}
         min={1}
-        onValueChange={(newVal) => setValue(newVal)}
+        onValueChange={([newVal]) => setValue(newVal)}
         {...props}
       >
         <Slider.Track className="SliderTrack">