Background library loading threads call GetRow() through
loadFromScope(), which writes to m_rowCache concurrently
with the main thread clearing it in loadTables(). The
unsynchronized access corrupts the map's red-black tree,
causing a double-free crash when switching projects.
Add m_rowCacheMutex to protect all m_rowCache accesses.
Also replace std::tie with std::make_tuple to avoid
unnecessary temporary conversions, and use a single
find() instead of contains() followed by at().
Move onUpdateUI from public to private in EDA_BASE_FRAME since
it is an internal event handler bound via Bind(), not part of
the public API.
Capture the empty-check result before erasing rows in
library_manager.cpp to avoid using invalidated iterators from
the subrange returned by std::ranges::remove_if.
Add null guards to the netHighlightCond toolbar condition
lambda in PCB_EDIT_FRAME to prevent null dereference during
shutdown, matching the pattern used by other toolbar
conditions fixed in f962de966b.
The `cleanupRemovedPCMLibraries` function used `wxFile::Exists()` to check
whether a library path still exists on disk. However, `wxFile::Exists()` only
checks for regular files, not directories.
Footprint libraries (.pretty) and design block libraries (.kicad_blocks) are
directories, not files.
Fix by using `wxFileName::Exists()` instead, which correctly handles both files
and directories.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/23128
When a library table file is corrupted or manually edited to contain a
different table type than expected (e.g., fp_lib_table content inside a
sym-lib-table file), the wxCHECK2 assertion in loadTables would fire.
Replace with a wxLogWarning and skip the mismatched table gracefully.
Fixes KICAD-9AB
Resolve URI expansion on the main thread before dispatching async
library enumeration tasks. The getUri() call accesses PROJECT text
variables and SETTINGS_MANAGER::Prj() which are not thread-safe.
When a project is unloaded while worker threads are still running,
they would access freed or modified data in PROJECT::TextVarResolver,
causing either an access violation in (KICAD-14DS) or an assertion
failure when the project list is empty (KICAD-11Q9).
Pre-computing the expanded URI on the main thread and passing it to
enumerateLibrary() as a parameter eliminates the data race.
Resolves KICAD-14DS
Resolves KICAD-11Q9
Break the most expensive header include chains that contaminate the
largest number of translation units
New lightweight headers for extractdded types:
font_metrics.h, mouse_drag_action.h, board_project_settings_params.h,
common_settings_internals.h, wx_infobar_message_type.h,
zone_layer_properties_grid.h
When a nested library table row is marked as disabled or hidden, its
contained libraries are now properly excluded from the flattened
library list returned by LIBRARY_MANAGER::Rows(). Previously, libraries
from disabled/hidden nested tables were incorrectly included.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/22784
Environment variable expansion in paths now receives the active project
context instead of null. This enables project-specific variables to
resolve correctly in output directories and configuration paths.
The three library adapters (symbol, footprint, design block) each had
their own AsyncLoad() and GetLibraryStatus() implementations that were
nearly identical. This moves both to the base class.
The per-library mutex is removed. Each adapter now uses a single
shared_mutex for its library map. Read operations take shared locks,
write operations take unique locks. This simplifies the locking model
from two levels to one.
Derived classes override a new enumerateLibrary() method to perform
type-specific enumeration. The base class handles threading, status
tracking, and error handling.
Also adds a new WithFootprintsForLibrary() routine that takes a callback
but handles the locking internally so callers don't need to remember
Also fixes nested tables being deleted out from under
the dialog.
Also fixes a bug where PANEL_DESIGN_BLOCK_LIB_TABLE
had fallen behind the the other two.
Make sure "Table" rows get a file picker instead of a
directory picker (return *.* from getFileTypes()).
Don't assert when we can't find a plugin for a
nested table.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/22731
When starting pcbnew in standalone mode and quickly opening a file, a race
condition could occur where background library loading threads tried to access
Prj() while the project list was being modified. This caused an assertion
failure: "no project in list".
The fix aborts any async library loads before modifying m_projects_list in
SETTINGS_MANAGER::LoadProject() and UnloadProject(). This ensures background
threads have completed before the project list becomes temporarily invalid.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/22697
Allows activating a display panel that shows a webpage designed to
provide instances of symbols, footprints, 3d models and spice models to
the designer.
The webpage can be installed via PCM or directly in the panel. Webpages
should be registered with the KiCad project in order to avoid a warning
when showing content.
Get rid of mocking of settings, instead
use actual QA test environment settings
Make sure to load null project at fixture startup
Improve XNODE attribute handling
Fix netlist detection regex for prettified output
Seth Hillbrand