By default, we want to maintain unit groups for symbols between
annotations. But it may be desired to reset them in case the annotation
is mixed up and you want a graphical reannotation.
This provides a checkbox to make it clear that we do not reset groups by
default but you can if you want to.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14259
When using "Reset existing annotations", multi-unit symbol groupings
were preserved from the existing (potentially incorrect) reference
designators. This caused bad annotations to persist even after reset.
The fix skips collecting locked multi-unit symbol groups when reset
is requested, allowing fresh groupings to be created based on symbol
placement rather than existing reference designators.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14259
When placing a design block as a group with auto-annotation enabled
and "Keep Annotations" disabled, symbols inside the group were not
being automatically annotated. This was because getInferredSymbols()
only handled SCH_SYMBOL_T and SCH_FIELD_T items in the selection,
but when placing as a group, only the SCH_GROUP_T is in the selection.
Fixed by adding a case for SCH_GROUP_T in getInferredSymbols() that
uses RunOnChildren() to recursively find all symbols within the
group, including nested groups.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/22620
Keep state for reuse in the class. This allows us to properly pick the
value when fully reannotating
Don't annotate when placing new units. Just step ahead in the unit
value while keeping the refdes number constant. This eliminates the
jumping around to unplaced units when placing new multi-unit symbols
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21378
Recommendation is to avoid using the year nomenclature as this
information is already encoded in the git repo. Avoids needing to
repeatly update.
Also updates AUTHORS.txt from current repo with contributor names
The sheet list is returned as a copy of the cached list rather than a
reference to prevent external code from changing the list. While not as
performant, it eliminates the risk of the sheet list being altered in
ways that could break the schematic. The sheet list should only be
updated by calling SCHEMATIC::RefreshHierarchy() when any appropriate
sheet changes are made.
Note to developers: there is something inherently different about how the
QA tests are loading and handling schematics versus the schematic editor.
Using the cached sheet list for the SCHEMATIC object will cause some QA
test to fail. This is why SCHEMATIC::Hierarchy() has not replaced
SCHEMATIC::BuildSheetListSortedByPageNumbers() everywhere.
Also removes the side-effect that SCH_SHEET_LIST's
c'tor would sort the list (and write virtual page
numbers) anytime the starting sheet was the root.
Also, definitely don't build a SHEET_LIST (sorted or
otherwise) if you're not even going to use it.
Also don't build SCH_SHEET_LISTs on idle events. Better
to just always have the Next Sheet button enabled (we
already beep if you click it and there's no next sheet).
Also, use a SCREEN_LIST when you can. It's much cheaper
to create.
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.
There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.
Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).
Provides a single-point access for modifying the schematic and symbol
elements that allows chaining updates and reverting partial changes.
Standardizes the undo hierarchy between pcb and schematic editors
As this is another layer on the existing undo/redo structure, the
initial commit does not replace all undo/redo calls currently existing.
These will be handled in a series of follow-on commits
When the designer asks to reset annotations, we reset all annotations
including power symbols. This may create additional churn in the files
but only when requested and is useful to fix schematic errors
Fixes https://gitlab.com/kicad/code/kicad/issues/13138
U1 and u1 are allowed but if they both exist in the same schematic, they
will throw an ERC and annotation error. Reannotating will make them U1
and u2.
Fixes https://gitlab.com/kicad/code/kicad/issues/11862
This can be a particular problem if you go to run ERC, it shows the
annotation warnging so you re-annotate (but don't notice that your
scope is set to Selection).
Also adds some missing defensive code around closing a modeless RC
checker before the document (which we had for DRC dialog but not the
ERC dialog).
Also fixes a missing override of GetSeverity which kept ERC messages
from having the right prefix.
Seth Hillbrand