From f5954b0d7dadbddac930ca9bcd2df7e159b137f2 Mon Sep 17 00:00:00 2001 From: Alex Shvartzkop Date: Sun, 14 Apr 2024 01:19:39 +0300 Subject: [PATCH] Fix some warnings. (cherry picked from commit affcfed6773be7eee5809c80554522e11d90ad49) --- common/background_jobs_monitor.cpp | 2 +- eeschema/fields_grid_table.cpp | 4 ---- eeschema/fields_grid_table.h | 1 - include/background_jobs_monitor.h | 2 -- 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/common/background_jobs_monitor.cpp b/common/background_jobs_monitor.cpp index e7c9e33151..aeb3dd2593 100644 --- a/common/background_jobs_monitor.cpp +++ b/common/background_jobs_monitor.cpp @@ -209,7 +209,7 @@ void BACKGROUND_JOB_REPORTER::AdvancePhase() } -BACKGROUND_JOBS_MONITOR::BACKGROUND_JOBS_MONITOR() : m_jobListDialog( nullptr ) +BACKGROUND_JOBS_MONITOR::BACKGROUND_JOBS_MONITOR() { } diff --git a/eeschema/fields_grid_table.cpp b/eeschema/fields_grid_table.cpp index 38e17ba357..e56463fccb 100644 --- a/eeschema/fields_grid_table.cpp +++ b/eeschema/fields_grid_table.cpp @@ -131,7 +131,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_BASE_FRAME* a WX_GRID* aGrid, LIB_SYMBOL* aSymbol ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_SYMBOL_T ), m_mandatoryFieldCount( MANDATORY_FIELDS ), m_part( aSymbol ), @@ -152,7 +151,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* a WX_GRID* aGrid, SCH_SYMBOL* aSymbol ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_SYMBOL_T ), m_mandatoryFieldCount( MANDATORY_FIELDS ), m_part( aSymbol->GetLibSymbolRef().get() ), @@ -173,7 +171,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* a WX_GRID* aGrid, SCH_SHEET* aSheet ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_SHEET_T ), m_mandatoryFieldCount( SHEET_MANDATORY_FIELDS ), m_part( nullptr ), @@ -193,7 +190,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* a WX_GRID* aGrid, SCH_LABEL_BASE* aLabel ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_LABEL_LOCATE_ANY_T ), m_mandatoryFieldCount( aLabel->GetMandatoryFieldCount() ), m_part( nullptr ), diff --git a/eeschema/fields_grid_table.h b/eeschema/fields_grid_table.h index 1eeb3c7004..810875733d 100644 --- a/eeschema/fields_grid_table.h +++ b/eeschema/fields_grid_table.h @@ -118,7 +118,6 @@ protected: private: SCH_BASE_FRAME* m_frame; DIALOG_SHIM* m_dialog; - WX_GRID* m_grid; KICAD_T m_parentType; int m_mandatoryFieldCount; LIB_SYMBOL* m_part; diff --git a/include/background_jobs_monitor.h b/include/background_jobs_monitor.h index 006a70a364..d4b37cc4e1 100644 --- a/include/background_jobs_monitor.h +++ b/include/background_jobs_monitor.h @@ -127,8 +127,6 @@ private: */ void jobUpdated( std::shared_ptr aJob ); - BACKGROUND_JOB_LIST* m_jobListDialog; - /** * Holds a reference to all active background jobs * Access to this vector should be protected by locks since threads may Create or Remove at will