Plotters: add plot Arcs using EDA_SHAPE or center, start point and end point.

It avoid trying to calculate arc angles (start, end or arc angle) that
frequently create issues due to reverse Y axis, plot mirrored and/or
angle normalization with different criteria.
Fixes #10914
https://gitlab.com/kicad/code/kicad/issues/10914

include/plotters/plotter.h

@@ -309,13 +309,24 @@ public:
     // Higher level primitives -- can be drawn as line, sketch or 'filled'
     virtual void ThickSegment( const VECTOR2I& start, const VECTOR2I& end, int width,
                                OUTLINE_MODE tracemode, void* aData );
-    virtual void ThickArc( const VECTOR2I& centre, const EDA_ANGLE& StAngle,
-                           const EDA_ANGLE& EndAngle, int rayon, int width,
-                           OUTLINE_MODE tracemode, void* aData );
+
+    virtual void ThickArc( const VECTOR2I& aCentre, const EDA_ANGLE& StAngle,
+                           const EDA_ANGLE& EndAngle, int aRadius, int aWidth,
+                           OUTLINE_MODE aTraceMode, void* aData );
+
+    virtual void ThickArc( const VECTOR2I& aCentre, const VECTOR2I& aStart,
+                           const VECTOR2I& aEnd, int aWidth,
+                           OUTLINE_MODE aTraceMode, void* aData );
+
+    virtual void ThickArc( const EDA_SHAPE& aArcShape,
+                           OUTLINE_MODE aTraceMode, void* aData );
+
     virtual void ThickRect( const VECTOR2I& p1, const VECTOR2I& p2, int width, OUTLINE_MODE tracemode,
                             void* aData );
+
     virtual void ThickCircle( const VECTOR2I& pos, int diametre, int width, OUTLINE_MODE tracemode,
                               void* aData );
+
     virtual void FilledCircle( const VECTOR2I& pos, int diametre, OUTLINE_MODE tracemode,
                                void* aData );
 

include/plotters/plotter_gerber.h

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2020 Jean-Pierre Charras, jp.charras at wanadoo.fr
- * Copyright (C) 2016-2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2016-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software: you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the
@@ -77,13 +77,23 @@ public:
     virtual void ThickSegment( const VECTOR2I& start, const VECTOR2I& end, int width,
                                OUTLINE_MODE tracemode, void* aData ) override;
 
-    virtual void ThickArc( const VECTOR2I& centre, const EDA_ANGLE& aStartAngle,
+    virtual void ThickArc( const VECTOR2I& aCentre, const EDA_ANGLE& aStartAngle,
                            const EDA_ANGLE& aEndAngle, int aRadius, int aWidth,
-                           OUTLINE_MODE tracemode, void* aData ) override;
+                           OUTLINE_MODE aTraceMode, void* aData ) override;
+
+    virtual void ThickArc( const VECTOR2I& aCentre, const VECTOR2I& aStart,
+                           const VECTOR2I& aEnd, int aWidth,
+                           OUTLINE_MODE aTraceMode, void* aData ) override;
+
+    virtual void ThickArc( const EDA_SHAPE& aArcShape,
+                           OUTLINE_MODE aTraceMode, void* aData ) override;
+
     virtual void ThickRect( const VECTOR2I& p1, const VECTOR2I& p2, int width,
                             OUTLINE_MODE tracemode, void* aData ) override;
+
     virtual void ThickCircle( const VECTOR2I& pos, int diametre, int width,
                               OUTLINE_MODE tracemode, void* aData ) override;
+
     virtual void FilledCircle( const VECTOR2I& pos, int diametre,
                               OUTLINE_MODE tracemode, void* aData ) override;
 

include/plotters/plotter_hpgl.h

@@ -1,7 +1,7 @@
 /*
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
- * Copyright (C) 2016-2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2016-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software: you can redistribute it and/or modify it
  * under the terms of the GNU General Public License as published by the
@@ -121,7 +121,12 @@ public:
     virtual void Arc( const VECTOR2I& aCenter, const EDA_ANGLE& aStartAngle,
                       const EDA_ANGLE& aEndAngle, int aRadius, FILL_T aFill,
                       int aWidth = USE_DEFAULT_LINE_WIDTH ) override;
+
+    virtual void Arc( const VECTOR2I& aCenter, const VECTOR2I& aStart, const VECTOR2I& aEnd,
+                      FILL_T aFill, int aWidth, int aMaxError ) override;
+
     virtual void PenTo( const VECTOR2I& pos, char plume ) override;
+
     virtual void FlashPadCircle( const VECTOR2I& aPadPos, int aDiameter,
                                  OUTLINE_MODE aTraceMode, void* aData ) override;
     virtual void FlashPadOval( const VECTOR2I& aPadPos, const VECTOR2I& aSize,