Plotters: add plot Arcs using EDA_SHAPE or center, start point and end point.

It avoid trying to calculate arc angles (start, end or arc angle) that
frequently create issues due to reverse Y axis, plot mirrored and/or
angle normalization with different criteria.
Fixes #10914
https://gitlab.com/kicad/code/kicad/issues/10914

common/plotters/HPGL_plotter.cpp

@@ -2,7 +2,7 @@
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
  * Copyright (C) 2017 Jean-Pierre Charras, jp.charras at wanadoo.fr
- * Copyright (C) 2020-2021 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 2020-2022 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -570,8 +570,6 @@ void HPGL_PLOTTER::ThickSegment( const VECTOR2I& start, const VECTOR2I& end,
 void HPGL_PLOTTER::Arc( const VECTOR2I& aCenter, const EDA_ANGLE& aStartAngle,
                         const EDA_ANGLE& aEndAngle, int aRadius, FILL_T aFill, int aWidth )
 {
-    wxASSERT( m_outputFile );
-
     if( aRadius <= 0 )
         return;
 
@@ -611,6 +609,18 @@ void HPGL_PLOTTER::Arc( const VECTOR2I& aCenter, const EDA_ANGLE& aStartAngle,
 }
 
 
+void HPGL_PLOTTER::Arc( const VECTOR2I& aCenter, const VECTOR2I& aStart,
+                        const VECTOR2I& aEnd,
+                        FILL_T aFill, int aWidth, int aMaxError )
+{
+    EDA_ANGLE startAngle( aStart - aCenter );
+    EDA_ANGLE endAngle( aEnd - aCenter );
+    int       radius = ( aStart - aCenter ).EuclideanNorm();
+
+    Arc( aCenter, -endAngle, -startAngle, radius, aFill, aWidth );
+}
+
+
 void HPGL_PLOTTER::FlashPadOval( const VECTOR2I& aPos, const VECTOR2I& aSize,
                                  const EDA_ANGLE& aOrient, OUTLINE_MODE aTraceMode, void* aData )
 {