From c624ee9cffd4ce29e18aef03f0806d22d7ed2803 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Thu, 1 Aug 2019 21:39:52 -0600 Subject: [PATCH] Re-parent new objects on duplicate. Fixes: lp:1838269 * https://bugs.launchpad.net/kicad/+bug/1838269 --- eeschema/tools/lib_edit_tool.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/eeschema/tools/lib_edit_tool.cpp b/eeschema/tools/lib_edit_tool.cpp index 2147d7c254..92a556eec7 100644 --- a/eeschema/tools/lib_edit_tool.cpp +++ b/eeschema/tools/lib_edit_tool.cpp @@ -712,15 +712,13 @@ int LIB_EDIT_TOOL::Duplicate( const TOOL_EVENT& aEvent ) if( !selection.Front()->IsMoving() ) saveCopyInUndoList( m_frame->GetCurPart(), UR_LIBEDIT ); - EDA_ITEMS newItems; - for( unsigned ii = 0; ii < selection.GetSize(); ++ii ) { LIB_ITEM* oldItem = static_cast( selection.GetItem( ii ) ); LIB_ITEM* newItem = (LIB_ITEM*) oldItem->Clone(); oldItem->ClearFlags( SELECTED ); newItem->SetFlags( IS_NEW | IS_PASTED | SELECTED ); - newItems.push_back( newItem ); + newItem->SetParent( part ); part->GetDrawItems().push_back( newItem ); getView()->Add( newItem );