Standardize pad type enums

pcbnew/plot_brditems_plotter.cpp

@@ -47,7 +47,7 @@
 #include <gbr_metadata.h>
 #include <gbr_netlist_metadata.h>             // for GBR_NETLIST_METADATA
 #include <layers_id_colors_and_visibility.h>  // for LSET, IsCopperLayer
-#include <pad_shapes.h>                       // for PAD_ATTRIB_HOLE_NOT_PLATED
+#include <pad_shapes.h>                       // for PAD_ATTRIB_NPTH
 #include <pcbplot.h>
 #include <pcb_plot_params.h>                  // for PCB_PLOT_PARAMS, PCB_PL...
 
@@ -122,7 +122,7 @@ void BRDITEMS_PLOTTER::PlotPad( D_PAD* aPad, COLOR4D aColor, EDA_DRAW_MODE_T aPl
         // Some pads are mechanical pads ( through hole or smd )
         // when this is the case, they have no pad name and/or are not plated.
         // In this case gerber files have slightly different attributes.
-        if( aPad->GetAttribute() == PAD_ATTRIB_HOLE_NOT_PLATED || aPad->GetName().IsEmpty() )
+        if( aPad->GetAttribute() == PAD_ATTRIB_NPTH || aPad->GetName().IsEmpty() )
             gbr_metadata.m_NetlistMetadata.m_NotInNet = true;
 
         if( !plotOnExternalCopperLayer )
@@ -145,11 +145,11 @@ void BRDITEMS_PLOTTER::PlotPad( D_PAD* aPad, COLOR4D aColor, EDA_DRAW_MODE_T aPl
         // has its aperture attribute set to GBR_APERTURE_ATTRIB_CONDUCTOR
         switch( aPad->GetAttribute() )
         {
-        case PAD_ATTRIB_HOLE_NOT_PLATED:    // Mechanical pad through hole
+        case PAD_ATTRIB_NPTH:       // Mechanical pad through hole
             gbr_metadata.SetApertureAttrib( GBR_APERTURE_METADATA::GBR_APERTURE_ATTRIB_WASHERPAD );
             break;
 
-        case PAD_ATTRIB_STANDARD :  // Pad through hole, a hole is also expected
+        case PAD_ATTRIB_PTH :       // Pad through hole, a hole is also expected
             gbr_metadata.SetApertureAttrib( GBR_APERTURE_METADATA::GBR_APERTURE_ATTRIB_COMPONENTPAD );
             break;
 
@@ -200,7 +200,7 @@ void BRDITEMS_PLOTTER::PlotPad( D_PAD* aPad, COLOR4D aColor, EDA_DRAW_MODE_T aPl
         }
 
         // Ensure NPTH pads have *always* the GBR_APERTURE_ATTRIB_WASHERPAD attribute
-        if( aPad->GetAttribute() == PAD_ATTRIB_HOLE_NOT_PLATED )
+        if( aPad->GetAttribute() == PAD_ATTRIB_NPTH )
             gbr_metadata.SetApertureAttrib( GBR_APERTURE_METADATA::GBR_APERTURE_ATTRIB_WASHERPAD );
     }
     else