From b7b28e555e26006752ec0210253aa21e4bdfcfff Mon Sep 17 00:00:00 2001 From: JamesJCode <13408010-JamesJCode@users.noreply.gitlab.com> Date: Mon, 10 Feb 2025 12:24:19 +0000 Subject: [PATCH] Fix potential data race (from Coverity warning 533646) --- pcbnew/tracks_cleaner.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pcbnew/tracks_cleaner.cpp b/pcbnew/tracks_cleaner.cpp index e4baf71acc..bb7150a74e 100644 --- a/pcbnew/tracks_cleaner.cpp +++ b/pcbnew/tracks_cleaner.cpp @@ -632,11 +632,8 @@ const std::vector& TRACKS_CLEANER::getConnectedItems( PCB const std::shared_ptr& connectivity = m_brd->GetConnectivity(); - if( !m_connectedItemsCache.contains( aTrack ) ) - { - std::lock_guard lock( m_mutex ); - m_connectedItemsCache[ aTrack ] = connectivity->GetConnectedItems( aTrack, connectedTypes ); - } + if( std::lock_guard lock( m_mutex ); !m_connectedItemsCache.contains( aTrack ) ) + m_connectedItemsCache[aTrack] = connectivity->GetConnectedItems( aTrack, connectedTypes ); return m_connectedItemsCache.at( aTrack ); }