From b7826dfdc32c5d2f50c43bbf20595acbf6356342 Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <seth@kipro-pcb.com>
Date: Thu, 19 Feb 2026 07:52:37 -0800
Subject: [PATCH] Fix irreflexive comparator in settings migration path sort

The version comparison lambda used >= 0, which returns true for
equal versions (compareVersions returns 0 for equal). This violates
strict weak ordering, causing undefined behavior in std::sort.
---
 common/settings/settings_manager.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/settings/settings_manager.cpp b/common/settings/settings_manager.cpp
index e49225f533..2e87a718c2 100644
--- a/common/settings/settings_manager.cpp
+++ b/common/settings/settings_manager.cpp
@@ -812,7 +812,7 @@ bool SETTINGS_MANAGER::GetPreviousVersionPaths( std::vector<wxString>* aPaths )
                    if( !extractVersion( verB ) )
                        return true;
 
-                   return compareVersions( verA, verB ) >= 0;
+                   return compareVersions( verA, verB ) > 0;
                } );
 
     return aPaths->size() > 0;