Update visibility flag when adding fields.

Also removes extra c'tor which fails to set the
ordinal.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/20556
This commit is contained in:
Jeff Young
2025-04-26 16:37:36 +01:00
parent 4dd39976a3
commit b01fef5ca8
24 changed files with 88 additions and 152 deletions
+3 -6
View File
@@ -803,8 +803,7 @@ void FIELDS_EDITOR_GRID_DATA_MODEL::ApplyData( SCH_COMMIT& aCommit )
for( const SCH_REFERENCE& instance : m_symbolsList )
{
SCH_SYMBOL& symbol = *instance.GetSymbol();
SCHEMATIC_SETTINGS& settings = symbol.Schematic()->Settings();
SCH_SYMBOL& symbol = *instance.GetSymbol();
aCommit.Modify( &symbol, instance.GetSheetPath().LastScreen() );
@@ -842,12 +841,10 @@ void FIELDS_EDITOR_GRID_DATA_MODEL::ApplyData( SCH_COMMIT& aCommit )
if( createField )
{
destField = symbol.AddField( SCH_FIELD( symbol.GetPosition(), FIELD_T::USER,
&symbol, srcName ) );
destField = symbol.AddField( SCH_FIELD( &symbol, FIELD_T::USER, srcName ) );
destField->SetTextAngle( symbol.GetField( FIELD_T::REFERENCE )->GetTextAngle() );
destField->SetTextSize( VECTOR2I( settings.m_DefaultTextSize,
settings.m_DefaultTextSize ) );
destField->SetVisible( false );
destField->SetTextPos( symbol.GetPosition() );
}
if( !destField )