From affcfed6773be7eee5809c80554522e11d90ad49 Mon Sep 17 00:00:00 2001 From: Alex Shvartzkop Date: Sun, 14 Apr 2024 01:19:39 +0300 Subject: [PATCH] Fix some warnings. --- common/background_jobs_monitor.cpp | 2 +- eeschema/fields_grid_table.cpp | 4 ---- eeschema/fields_grid_table.h | 1 - eeschema/sync_sheet_pin/dialog_sync_sheet_pins.cpp | 2 +- include/background_jobs_monitor.h | 2 -- 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/common/background_jobs_monitor.cpp b/common/background_jobs_monitor.cpp index e7c9e33151..aeb3dd2593 100644 --- a/common/background_jobs_monitor.cpp +++ b/common/background_jobs_monitor.cpp @@ -209,7 +209,7 @@ void BACKGROUND_JOB_REPORTER::AdvancePhase() } -BACKGROUND_JOBS_MONITOR::BACKGROUND_JOBS_MONITOR() : m_jobListDialog( nullptr ) +BACKGROUND_JOBS_MONITOR::BACKGROUND_JOBS_MONITOR() { } diff --git a/eeschema/fields_grid_table.cpp b/eeschema/fields_grid_table.cpp index 2a54882cc2..48dbf4c099 100644 --- a/eeschema/fields_grid_table.cpp +++ b/eeschema/fields_grid_table.cpp @@ -130,7 +130,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_BASE_FRAME* aFra LIB_SYMBOL* aSymbol ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_SYMBOL_T ), m_mandatoryFieldCount( MANDATORY_FIELDS ), m_part( aSymbol ), @@ -150,7 +149,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* aFra SCH_SYMBOL* aSymbol ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_SYMBOL_T ), m_mandatoryFieldCount( MANDATORY_FIELDS ), m_part( aSymbol->GetLibSymbolRef().get() ), @@ -170,7 +168,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* aFra SCH_SHEET* aSheet ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_SHEET_T ), m_mandatoryFieldCount( SHEET_MANDATORY_FIELDS ), m_part( nullptr ), @@ -189,7 +186,6 @@ FIELDS_GRID_TABLE::FIELDS_GRID_TABLE( DIALOG_SHIM* aDialog, SCH_EDIT_FRAME* aFra SCH_LABEL_BASE* aLabel ) : m_frame( aFrame ), m_dialog( aDialog ), - m_grid( aGrid ), m_parentType( SCH_LABEL_LOCATE_ANY_T ), m_mandatoryFieldCount( aLabel->GetMandatoryFieldCount() ), m_part( nullptr ), diff --git a/eeschema/fields_grid_table.h b/eeschema/fields_grid_table.h index 5605044a46..a294862ed1 100644 --- a/eeschema/fields_grid_table.h +++ b/eeschema/fields_grid_table.h @@ -116,7 +116,6 @@ protected: private: SCH_BASE_FRAME* m_frame; DIALOG_SHIM* m_dialog; - WX_GRID* m_grid; KICAD_T m_parentType; int m_mandatoryFieldCount; LIB_SYMBOL* m_part; diff --git a/eeschema/sync_sheet_pin/dialog_sync_sheet_pins.cpp b/eeschema/sync_sheet_pin/dialog_sync_sheet_pins.cpp index 66a01d317b..cb76fc5f42 100644 --- a/eeschema/sync_sheet_pin/dialog_sync_sheet_pins.cpp +++ b/eeschema/sync_sheet_pin/dialog_sync_sheet_pins.cpp @@ -52,7 +52,7 @@ DIALOG_SYNC_SHEET_PINS::DIALOG_SYNC_SHEET_PINS( wxWindow* aParent, wxImageList* imageList = new wxImageList( SYNC_SHEET_PIN_PREFERENCE::NORMAL_WIDTH, SYNC_SHEET_PIN_PREFERENCE::NORMAL_HEIGHT ); - for( const auto [icon_idx, bitmap] : SYNC_SHEET_PIN_PREFERENCE::GetBookctrlPageIcon() ) + for( const auto& [icon_idx, bitmap] : SYNC_SHEET_PIN_PREFERENCE::GetBookctrlPageIcon() ) { imageList->Add( KiBitmap( bitmap, SYNC_SHEET_PIN_PREFERENCE::NORMAL_HEIGHT ) ); } diff --git a/include/background_jobs_monitor.h b/include/background_jobs_monitor.h index 762d8da4ec..107c8e15b3 100644 --- a/include/background_jobs_monitor.h +++ b/include/background_jobs_monitor.h @@ -128,8 +128,6 @@ private: */ void jobUpdated( std::shared_ptr aJob ); - BACKGROUND_JOB_LIST* m_jobListDialog; - /** * Holds a reference to all active background jobs * Access to this vector should be protected by locks since threads may Create or Remove at will