electron-rare/kicad-source-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pathspec lifetime issue

Browse Source 
Don't let stack pointers go out of scope before using

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21417
This commit is contained in:
Seth Hillbrand
2025-08-02 12:33:55 -07:00
parent d91cce930f
commit a7ab02224e
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/git/git_status_handler.cpp
+8 -4
View File
@@ -75,12 +75,16 @@ std::map<wxString, FileStatus> GIT_STATUS_HANDLER::GetFileStatus( const wxString
status_options.flags = GIT_STATUS_OPT_INCLUDE_UNTRACKED | GIT_STATUS_OPT_INCLUDE_UNMODIFIED;
// Set up pathspec if provided
const char* pathspec_cstr = nullptr;
std::string pathspec_str;
std::vector<const char*> pathspec_ptrs;
if( !aPathspec.IsEmpty() )
{
pathspec_cstr = aPathspec.c_str().AsChar();
const char* pathspec[] = { pathspec_cstr };
status_options.pathspec = { (char**) pathspec, 1 };
pathspec_str = aPathspec.ToStdString();
pathspec_ptrs.push_back( pathspec_str.c_str() );
status_options.pathspec.strings = const_cast<char**>( pathspec_ptrs.data() );
status_options.pathspec.count = pathspec_ptrs.size();
}
git_status_list* status_list = nullptr;