From 8b1771b03ecbd74d7ccd31a6ebd11f1dcdcf186b Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Fri, 19 Feb 2021 12:18:23 -0800 Subject: [PATCH] Remove assertion on SELECTION_CONDITION The proposed overload did not compile on gcc and using adjustments to get to compile by moving definition into cpp results in false positives. This is removed until we can come up with a better solution and test --- include/tool/selection_conditions.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/include/tool/selection_conditions.h b/include/tool/selection_conditions.h index fc68aa1b4b..d4d482764f 100644 --- a/include/tool/selection_conditions.h +++ b/include/tool/selection_conditions.h @@ -62,15 +62,6 @@ SELECTION_CONDITION operator&&( const SELECTION_CONDITION& aConditionA, SELECTION_CONDITION operator&&( SELECTION_BOOL aConditionA, const SELECTION_CONDITION& aConditionB ); -// We don't use uninitialized SELECTION_CONDITIONs, so casting to bool is probably -// a programming error. -template<> SELECTION_CONDITION::operator bool() const noexcept -{ - wxASSERT( "Incorrect use of SELECTION_CONDITION" ); - return false; -}; - - /** * Class that groups generic conditions for selected items. */