From 7da3f06ca6221d8731cce3321213a9e36bb65418 Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sat, 31 Jan 2026 12:47:52 +0000 Subject: [PATCH] Clean up TODO. While it might be tempting to put these in the individual property setters, there's no well-defined order in which they're called, and many of the consistency checks are between multiple properties. --- pcbnew/padstack.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pcbnew/padstack.cpp b/pcbnew/padstack.cpp index 84b4ea53da..08eb24e0c4 100644 --- a/pcbnew/padstack.cpp +++ b/pcbnew/padstack.cpp @@ -99,9 +99,10 @@ PADSTACK& PADSTACK::operator=( const PADSTACK &aOther ) m_frontPostMachining = aOther.m_frontPostMachining; m_backPostMachining = aOther.m_backPostMachining; - // Data consistency enforcement logic that used to live in the pad properties dialog - // TODO(JE) Should these move to individual property setters, so that they are always - // enforced even through the properties panel and API? + // Data consistency enforcement logic that used to live in the pad properties dialog. + // While it might be tempting to put these in the individual property setters, there's no + // well-defined order in which they're called, and many of the consistency checks are + // between multiple properties. ForEachUniqueLayer( [&]( PCB_LAYER_ID aLayer )