From 7ca472deb8397aaa7e7629c7a0c0cb9b5e47541f Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Fri, 13 Sep 2024 16:03:58 -0700 Subject: [PATCH] Handle error when we don't have Eagle Board This can also occur in libraries, so ensure we're not dereferencing a null board pointer Fixes https://gitlab.com/kicad/code/kicad/-/issues/18702 (cherry picked from commit 89b9b13e21580f89354b2895a0fd7de296a10bc3) --- pcbnew/pcb_io/eagle/pcb_io_eagle.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pcbnew/pcb_io/eagle/pcb_io_eagle.cpp b/pcbnew/pcb_io/eagle/pcb_io_eagle.cpp index 05497a289d..531bf2aed3 100644 --- a/pcbnew/pcb_io/eagle/pcb_io_eagle.cpp +++ b/pcbnew/pcb_io/eagle/pcb_io_eagle.cpp @@ -2035,7 +2035,12 @@ void PCB_IO_EAGLE::packagePad( FOOTPRINT* aFootprint, wxXmlNode* aTree ) } else { - wxLogError( _( "Invalid zero-sized pad ignored in\nfile: %s" ), m_board->GetFileName() ); + wxFileName fileName( m_lib_path ); + + if( m_board) + wxLogError( _( "Invalid zero-sized pad ignored in\nfile: %s" ), m_board->GetFileName() ); + else + wxLogError( _( "Invalid zero-sized pad ignored in\nfile: %s" ), fileName.GetFullName() ); } }