From 66bd0f850aecdca28ed74b46eabffedb92df0795 Mon Sep 17 00:00:00 2001
From: Seth Hillbrand <seth@kipro-pcb.com>
Date: Wed, 17 Apr 2024 09:56:44 -0700
Subject: [PATCH] Allow NIC pins to be stacked

Previously, we only allowed pins of the same time as well as passive
pins to be stacked.  This change allows NIC pins as well since they are
not internally connected, there is no reason that they cannot be tied to
another pin electrically

(cherry picked from commit 0e0ada8e4e5578107c63540861981d9ad0e0843b)
---
 eeschema/sch_pin.cpp | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/eeschema/sch_pin.cpp b/eeschema/sch_pin.cpp
index 04def6978c..a942e3d30a 100644
--- a/eeschema/sch_pin.cpp
+++ b/eeschema/sch_pin.cpp
@@ -286,11 +286,16 @@ void SCH_PIN::GetMsgPanelInfo( EDA_DRAW_FRAME* aFrame, std::vector<MSG_PANEL_ITE
 
 bool SCH_PIN::IsStacked( const SCH_PIN* aPin ) const
 {
+    bool isConnectableType_a = GetType() == ELECTRICAL_PINTYPE::PT_PASSIVE
+                            || GetType() == ELECTRICAL_PINTYPE::PT_NIC;
+    bool isConnectableType_b = aPin->GetType() == ELECTRICAL_PINTYPE::PT_PASSIVE
+                            || aPin->GetType() == ELECTRICAL_PINTYPE::PT_NIC;
+
     return m_parent == aPin->GetParent()
            && GetTransformedPosition() == aPin->GetTransformedPosition()
            && GetName() == aPin->GetName()
-           && ( ( GetType() == aPin->GetType() ) || ( GetType() == ELECTRICAL_PINTYPE::PT_PASSIVE )
-                || ( aPin->GetType() == ELECTRICAL_PINTYPE::PT_PASSIVE ) );
+           && ( ( GetType() == aPin->GetType() )
+                || isConnectableType_a || isConnectableType_b );
 }