From 65dfee161bf614c3364017bfbbd92b350e1e6aca Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sat, 31 May 2025 21:30:00 +0100 Subject: [PATCH] Read Altium's showName property for fields. Also fixes a potential crash bug in schematic cleanup when breaking lines that are part of a group. Fixes https://gitlab.com/kicad/code/kicad/-/issues/20985 --- eeschema/sch_io/altium/sch_io_altium.cpp | 1 + eeschema/sch_line.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/eeschema/sch_io/altium/sch_io_altium.cpp b/eeschema/sch_io/altium/sch_io_altium.cpp index d268b72fe7..da2aacd0f3 100644 --- a/eeschema/sch_io/altium/sch_io_altium.cpp +++ b/eeschema/sch_io/altium/sch_io_altium.cpp @@ -4389,6 +4389,7 @@ void SCH_IO_ALTIUM::ParseParameter( const std::map& aPropert field->SetText( kicadText ); field->SetPosition( elem.location + m_sheetOffset ); field->SetVisible( !elem.isHidden ); + field->SetNameShown( elem.isShowName ); SetTextPositioning( field, elem.justification, elem.orientation ); } } diff --git a/eeschema/sch_line.cpp b/eeschema/sch_line.cpp index 3937ec120d..adc7bd324d 100644 --- a/eeschema/sch_line.cpp +++ b/eeschema/sch_line.cpp @@ -545,7 +545,7 @@ SCH_LINE* SCH_LINE::MergeOverlap( SCH_SCREEN* aScreen, SCH_LINE* aLine, bool aCh SCH_LINE* SCH_LINE::BreakAt( SCH_COMMIT* aCommit, const VECTOR2I& aPoint ) { - SCH_LINE* newSegment = static_cast( Duplicate( aCommit ) ); + SCH_LINE* newSegment = static_cast( Duplicate( true, aCommit ) ); newSegment->SetStartPoint( aPoint ); newSegment->SetConnectivityDirty( true );