From 5619cc41f96f023350c19bbb56bcb7ebfabad844 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Thu, 14 Mar 2019 07:51:43 -0700 Subject: [PATCH] Remove Bsymbolic linker flag Bsymbolic prevents DSO exceptions from being handled by the calling application. This was added when some toolchains did not fully support the -fhidden-visibility setting. Every platform now support it, so we can remove the hammer. See https://bugs.launchpad.net/kicad/+bug/1322354 for original details --- CMakeLists.txt | 7 ------- 1 file changed, 7 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b8e34f8362..28b262d802 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -344,13 +344,6 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) set( CMAKE_MODULE_LINKER_FLAGS "-Wl,--no-undefined" ) set( CMAKE_EXE_LINKER_FLAGS_RELEASE "-s" ) - - # Defeat ELF's ability to use the GOT to replace locally implemented functions - # with ones from another module. - # https://bugs.launchpad.net/kicad/+bug/1322354 - set( CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-Bsymbolic" ) - set( CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-Bsymbolic" ) - endif() if( APPLE )