From 4a00f058a6e596fdec920c1b0cc7179ffb37d436 Mon Sep 17 00:00:00 2001 From: Seth Hillbrand Date: Tue, 24 Feb 2026 08:30:29 -0800 Subject: [PATCH] qa_cli: update ERC test fixtures for severity reporting Commit a5f5298cad added severity headers to ERC report output but didn't update the CLI test reference files. Update the golden .rpt files to include the new "Report includes:" header line, update the .json golden file to include the new "included_severities" array, and bump the JSON test's line_skip_count from 5 to 9 to skip past the new block and the kicad_version field during comparison. --- qa/data/cli/basic_test/basic_test.erc.json | 4 ++++ qa/data/cli/basic_test/basic_test.erc.rpt | 1 + qa/data/cli/basic_test/basic_test.erc.unitsin.rpt | 1 + qa/tests/cli/test_sch.py | 2 +- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/qa/data/cli/basic_test/basic_test.erc.json b/qa/data/cli/basic_test/basic_test.erc.json index 784655816e..b220aabdad 100644 --- a/qa/data/cli/basic_test/basic_test.erc.json +++ b/qa/data/cli/basic_test/basic_test.erc.json @@ -2,6 +2,10 @@ "$schema": "https://schemas.kicad.org/erc.v1.json", "coordinate_units": "mm", "date": "2025-08-20T22:30:33+0000", + "included_severities": [ + "error", + "warning" + ], "kicad_version": "9.0.4", "sheets": [ { diff --git a/qa/data/cli/basic_test/basic_test.erc.rpt b/qa/data/cli/basic_test/basic_test.erc.rpt index 01e9de4ba5..4cf38114e8 100644 --- a/qa/data/cli/basic_test/basic_test.erc.rpt +++ b/qa/data/cli/basic_test/basic_test.erc.rpt @@ -1,4 +1,5 @@ ERC report (2025-08-20T22:30:33+0000, Encoding UTF8) +Report includes: Errors, Warnings ***** Sheet / [power_pin_not_driven]: Input Power pin not driven by any Output Power pins diff --git a/qa/data/cli/basic_test/basic_test.erc.unitsin.rpt b/qa/data/cli/basic_test/basic_test.erc.unitsin.rpt index 0157a1fddf..d99b41a615 100644 --- a/qa/data/cli/basic_test/basic_test.erc.unitsin.rpt +++ b/qa/data/cli/basic_test/basic_test.erc.unitsin.rpt @@ -1,4 +1,5 @@ ERC report (2025-08-20T22:30:34+0000, Encoding UTF8) +Report includes: Errors, Warnings ***** Sheet / [power_pin_not_driven]: Input Power pin not driven by any Output Power pins diff --git a/qa/tests/cli/test_sch.py b/qa/tests/cli/test_sch.py index 94a00a653a..e66d1ffe48 100644 --- a/qa/tests/cli/test_sch.py +++ b/qa/tests/cli/test_sch.py @@ -170,7 +170,7 @@ def test_sch_export_pythonbom( kitest, @pytest.mark.parametrize("test_file,output_fn,line_skip_count,skip_compare,expected_exit_code,cli_args", [("cli/basic_test/basic_test.kicad_sch", "basic_test.erc.rpt", 1, False, 0, []), ("cli/basic_test/basic_test.kicad_sch", "basic_test.erc.rpt", 1, False, 0, ["--format=report"]), - ("cli/basic_test/basic_test.kicad_sch", "basic_test.erc.json", 5, False,0, ["--format=json"]), + ("cli/basic_test/basic_test.kicad_sch", "basic_test.erc.json", 9, False,0, ["--format=json"]), ("cli/basic_test/basic_test.kicad_sch", "basic_test.erc.unitsin.rpt", 1, False, 0, ["--format=report", "--units=in"]), ]) def test_sch_export_erc( kitest,