From 4174ecf4c3ff004f2dc1ef3acc0e3146bbece48e Mon Sep 17 00:00:00 2001 From: Jeff Young Date: Sat, 1 Sep 2018 00:44:00 +0100 Subject: [PATCH] Only validate via size vs drill if both are specified. Fixes: lp:1789349 * https://bugs.launchpad.net/kicad/+bug/1789349 --- pcbnew/dialogs/dialog_track_via_properties.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pcbnew/dialogs/dialog_track_via_properties.cpp b/pcbnew/dialogs/dialog_track_via_properties.cpp index 0014ad6a69..666499b7df 100644 --- a/pcbnew/dialogs/dialog_track_via_properties.cpp +++ b/pcbnew/dialogs/dialog_track_via_properties.cpp @@ -370,7 +370,9 @@ bool DIALOG_TRACK_VIA_PROPERTIES::TransferDataFromWindow() if( !m_viaDiameter.Validate( true ) || !m_viaDrill.Validate( true ) ) return false; - if( !m_trackNetclass->IsChecked() && m_viaDiameter.GetValue() <= m_viaDrill.GetValue() ) + if( m_ViaDiameterCtrl->IsEnabled() && !m_viaDiameter.IsIndeterminate() + && m_ViaDrillCtrl->IsEnabled() && !m_viaDrill.IsIndeterminate() + && m_viaDiameter.GetValue() <= m_viaDrill.GetValue() ) { DisplayError( GetParent(), _( "Via drill size must be smaller than via diameter" ) ); m_ViaDrillCtrl->SelectAll();